-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for select multiple request. #1130
Open
rohitjakhar
wants to merge
16
commits into
ChuckerTeam:main
Choose a base branch
from
rohitjakhar:share_multiple_request
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
73437f8
Add Multiple Section in transaction list.
rohitjakhar 6a9eb8d
Fix variable naming.
rohitjakhar abdb4c5
Fix ktlint
rohitjakhar 0850127
Concise code.
rohitjakhar d80d386
Update library/src/main/res/values/strings.xml
rohitjakhar d453d6d
Update library/src/main/res/values/strings.xml
rohitjakhar 7dad7ff
Notify adapter after deleting item from list.
rohitjakhar 882d623
move selected item code inside viewmodel.
rohitjakhar 9e41073
fix reselecting. click after clear selection issue.
rohitjakhar 5b58ed1
Merge branch 'main' of https://github.com/rohitjakhar/chucker into shβ¦
rohitjakhar 4a8ecdd
Fix deket
rohitjakhar 5ce5445
KotlinLint Format
rohitjakhar 05427fe
Fix: Persistent user selection
rohitjakhar d5461e4
Merge branch 'main' of https://github.com/rohitjakhar/ComposeChucker β¦
rohitjakhar c107409
Update code.
rohitjakhar 137d8c7
Suppress MainActivity with TooManyFunction.
rohitjakhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of this, the function is now getting too long and letting detekt fail:
You can see it in the CI signal.
Can you export this + lines 193/199 to separate functions