-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include FastFurnace mod (features). #176
Include FastFurnace mod (features). #176
Conversation
Fast Furnace is superseded by UT. There's no need to bundle it in |
Moving fixes for vanilla directly into Cleanroom is one of our goal |
I don't think this is true, UT caches crafting recipes only (so that's FastWorkbench functionality?). If I remember correctly, CensoredASM is the one that supersedes FastFurnace, and it mixins into |
so run the game with FF is safety. I have not checked the code of CASM or UT. |
@@ -1,6 +1,40 @@ | |||
--- before/net/minecraft/tileentity/TileEntityFurnace.java | |||
+++ after/net/minecraft/tileentity/TileEntityFurnace.java | |||
@@ -37,20 +37,18 @@ | |||
@@ -3,6 +3,7 @@ | |||
import net.minecraft.block.Block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the full class name, don't patch the import
This is a waste of text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
I tested the compability this feature with UT or FastFurnace. |
It's better to use loliasm's implementation than fastfurnace's. |
Ok |
Summary
Included the FastFurnace mod.
Not FastWorkbench.