Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include FastFurnace mod (features). #176

Closed

Conversation

Oganesson897
Copy link

@Oganesson897 Oganesson897 commented Jul 25, 2024

Summary

Included the FastFurnace mod.
Not FastWorkbench.

@Oregano1963
Copy link

Fast Furnace is superseded by UT. There's no need to bundle it in

@kappa-maintainer
Copy link
Collaborator

Moving fixes for vanilla directly into Cleanroom is one of our goal
The only problem is, will this PR crash UT's mixin?

@jchung01
Copy link

Fast Furnace is superseded by UT. There's no need to bundle it in

I don't think this is true, UT caches crafting recipes only (so that's FastWorkbench functionality?). If I remember correctly, CensoredASM is the one that supersedes FastFurnace, and it mixins into FurnaceRecipes, not TileEntityFurnace. You might want to check Rong's impl in CASM if it's better than FastFurnace and use that.

@Oganesson897
Copy link
Author

Oganesson897 commented Jul 26, 2024

FastFurnace replaced the furnace block, and it will be override the createNewTileEntity function to creat the faster furnace tile entity.

so run the game with FF is safety.
I searched furnace keywords in UT's curse page, but not found any info of FastFurnace Included.

I have not checked the code of CASM or UT.
btw i merged the TileFastFurnace class into vanila furnace tile code, not more.

@@ -1,6 +1,40 @@
--- before/net/minecraft/tileentity/TileEntityFurnace.java
+++ after/net/minecraft/tileentity/TileEntityFurnace.java
@@ -37,20 +37,18 @@
@@ -3,6 +3,7 @@
import net.minecraft.block.Block;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the full class name, don't patch the import
This is a waste of text.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@Oganesson897
Copy link
Author

I tested the compability this feature with UT or FastFurnace.
Not crash and furnace is workable.

@Oganesson897 Oganesson897 changed the title Included FastFurnace mod (features). Include FastFurnace mod (features). Jul 30, 2024
@Rongmario
Copy link
Member

It's better to use loliasm's implementation than fastfurnace's.

@Oganesson897
Copy link
Author

It's better to use loliasm's implementation than fastfurnace's.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants