Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lwjgl3ify #233

Merged

Conversation

Ecdcaeb
Copy link
Contributor

@Ecdcaeb Ecdcaeb commented Nov 2, 2024

Include

Compatibility and warning fixes

GTNewHorizons/lwjgl3ify@999b8c1
details : org.lwjgl.input.Controllers, org.lwjglx.input.Controller

Issues

#211

[17:25:10] [Thread-404/ERROR] [Foundation]: Thread[#522,Thread-404,5,main]
java.lang.NoClassDefFoundError: org/lwjgl/input/Controllers
	at mcinterface1122.InterfaceInput.lambda$initJoysticks$0(InterfaceInput.java:102) ~[InterfaceInput.class:?]
	at java.base/java.lang.Thread.run(Thread.java:1570) [?:?]
Caused by: java.lang.ClassNotFoundException: org.lwjgl.input.Controllers
	at top.outlands.foundation.boot.ActualClassLoader.findClass(ActualClassLoader.java:259) ~[foundation-0.13.9.jar:?]
	at top.outlands.foundation.boot.ActualClassLoader.loadClass(ActualClassLoader.java:266) ~[foundation-0.13.9.jar:?]
	... 2 more
Caused by: java.lang.ClassNotFoundException
	at top.outlands.foundation.boot.ActualClassLoader.findClass(ActualClassLoader.java:249) ~[foundation-0.13.9.jar:?]
	at top.outlands.foundation.boot.ActualClassLoader.loadClass(ActualClassLoader.java:266) ~[foundation-0.13.9.jar:?]
	... 2 more

Fix key name display on non-QWERTY keyboard layouts

GTNewHorizons/lwjgl3ify@7bd0ab5

Issues

#96

Fix missing key index mappings

GTNewHorizons/lwjgl3ify@3c03c17

Fix handling of Ctrl+Alt vs AltGr on Windows

GTNewHorizons/lwjgl3ify@8e5ce1e

Add Config Toggle to Enable / Disable HRTF Bools in OpenAl

GTNewHorizons/lwjgl3ify@2229295

Fix Display.isCloseRequested not resetting the flag upon call like in lwjgl2

GTNewHorizons/lwjgl3ify@ba6e459

Add missing Display functions

GTNewHorizons/lwjgl3ify@5edf02f

Fix some lwjgl type references, remove spaceinvaders * remove /test only

GTNewHorizons/lwjgl3ify@4286ae1

ForgeEarlyConfig

sync Config.Comment from Config to ForgeEarlyConfig
some todo in ForgeEarlyConfig

# Linux-only - change the X11 class name, which is used by your window manager to identify the running application
    S:X11_CLASS_NAME=minecraft

    openal_context {
        # Enable HRTF sound support
        B:ENABLE_HRTF=false
    }

Add borderless fullscreen, make fullscreen choose the appropriate monitor

GTNewHorizons/lwjgl3ify@0e16c68

Start the game centered (toggleable in config)

GTNewHorizons/lwjgl3ify@cadb8f6

@kappa-maintainer
Copy link
Collaborator

All two commits should be included

@Rongmario
Copy link
Member

LGTM, kappa can merge it

@kappa-maintainer
Copy link
Collaborator

Should add a good pull request label later...

@kappa-maintainer kappa-maintainer merged commit ea9fd21 into CleanroomMC:experimental/foundation Nov 3, 2024
1 check passed
@Ecdcaeb Ecdcaeb deleted the lwjgl3ify branch November 4, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants