Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More one degree simulation #260

Merged
merged 16 commits into from
Nov 19, 2024
Merged

More one degree simulation #260

merged 16 commits into from
Nov 19, 2024

Conversation

simone-silvestri
Copy link
Collaborator

this PR is to continue working and collaborating on the experiments/one_degree_simulations/one_degree_simulation.jl file to get a stable one degree simulation set up

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (725e985) to head (3d4fa84).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/DataWrangling/ECCO/ECCO.jl 0.00% 3 Missing ⚠️
src/DataWrangling/ECCO/ECCO_mask.jl 0.00% 2 Missing ⚠️
src/DataWrangling/inpaint_mask.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #260   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         33      33           
  Lines       1869    1869           
=====================================
  Misses      1869    1869           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@simone-silvestri
Copy link
Collaborator Author

The one degree simulation as it stands NaNs with velocities increasing drastically very quickly.

@glwagner glwagner mentioned this pull request Nov 19, 2024
@glwagner
Copy link
Member

should we merge this asap

@simone-silvestri
Copy link
Collaborator Author

there is a problem with GM, see CliMA/Oceananigans.jl#3938. However probably better to merge this and continue in another PR

@glwagner glwagner merged commit b18d9bd into main Nov 19, 2024
19 checks passed
@navidcy
Copy link
Collaborator

navidcy commented Nov 20, 2024

Should we include the 1-degree, tripolar simulation in the docs?

@glwagner
Copy link
Member

not until we sort out fluxes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants