Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsopycnalSkewSymmetricDiffusivity has a performance issue #3938

Open
simone-silvestri opened this issue Nov 19, 2024 · 2 comments
Open

IsopycnalSkewSymmetricDiffusivity has a performance issue #3938

simone-silvestri opened this issue Nov 19, 2024 · 2 comments
Labels
GPU 👾 Where Oceananigans gets its powers from performance 🏍️ So we can get the wrong answer even faster

Comments

@simone-silvestri
Copy link
Collaborator

On ClimaOcean.jl, a one-degree simulation runs on a H100 GPU with:
Screenshot 2024-11-19 at 7 48 35 AM
which is terribly slow (about 8 SYPD with 20 minute timestep).

Removing https://github.com/CliMA/ClimaOcean.jl/blob/5a32b3599b2c3e24461ab3ff4727e010ac366aa4/experiments/one_degree_simulation/one_degree_simulation.jl#L48
from the closures leads to
Screenshot 2024-11-19 at 7 50 35 AM
about 140 SYPD with a 20 minute timestep
@simone-silvestri simone-silvestri changed the title Isopycnal IsopycnalSkewSymmetricDiffusivity has a performance issue Nov 19, 2024
@simone-silvestri simone-silvestri mentioned this issue Nov 19, 2024
Merged
@glwagner
Copy link
Member

Heck yea nice find. Note there is a refactoring occurring on #3901. You should probably test that PR

@glwagner
Copy link
Member

What about on CPU?

@glwagner glwagner mentioned this issue Nov 19, 2024
Open
@navidcy navidcy added performance 🏍️ So we can get the wrong answer even faster GPU 👾 Where Oceananigans gets its powers from labels Nov 22, 2024
@simone-silvestri simone-silvestri mentioned this issue Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GPU 👾 Where Oceananigans gets its powers from performance 🏍️ So we can get the wrong answer even faster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@navidcy @glwagner @simone-silvestri