Upwards list support(Addresses #328, X11/Wayland/Cairo) #364
Conversation
Add upwards list support for X11, as well as refactor/improve some drawing code and flags.
merrittlj
force-pushed
the
feature_upwards_list
branch
from
45bc4dc to
bf8319d
Compare
|
|
Fix many issues with styling related to bemenu and the upwards list mode. In addition to this, fix/modify some behavior to improve this(ex: border_size and border_radius are now a double).
Add necessary functions for Wayland upwards list mode to work.
merrittlj
force-pushed
the
feature_upwards_list
branch
from
f5634d5 to
8f0bfcb
Compare
merrittlj
changed the title
|
@Cloudef This pull request is now ready to review, upwards list mode/support is fully implemented in X11 and Wayland. I am unable to test Wayland(so I would reccomend someone else tests this), but it is compiling, and I believe my implementation is correct according to the Wayland documentation; and the platform-specific implementation is very small anyways. I did not implement Curses, but I believe Curses should be caught up-to-speed with other features(such as fixed-height) separately before I go ahead with that. |
|
Feel free to go ahead with reviewing smaller details, but my approach as a whole to this problem may need to be reviewed as well. However, I believe my solution and implementation has practicality to it, and will likely not need to be reworked. |
|
Looks good, thanks! |
Implement upwards list parameters, documentation, etc. as well as refactor some related Cairo code.
This is now fully implemented in X11, but Wayland will be implemented soon due to the large amount of the changes being related to Cairo, instead of X11. For now, this pull request will be a draft until I add support for Wayland and (maybe)Curses.
Regarding Curses, it is likely that I will try and merge this pull request with Wayland and X11 support, and then start work on catching Curses up to speed feature-wise seperately, as it is missing some features such as fixed-height and similar.
From #328