#327 Map search across all maps #328
Conversation
devo1929
commented
Apr 21, 2022
devo1929
commented
|
Nightly build for this pull request:
|
|
Why are you adding this functionality? Searching for maps within the current game mode is preferred imo |
It removes the limitation that you must know the game mode a map is in to find it. If I can't remember the game mode, I can still search for it across all maps and it'll find it and show me the game mode. What's the reason for preferring it to stay within the game mode? |
|
In the screenshot you showed there it is very confusing, a player searching for the official Mayflower map is now presented with 5 other options. Not great |
|
If anything add a toggle to enable that. By default it should search within the current game mode |
IMO, the names "Battle" and "Standard" are confusing. To me, they don't mean "Official" and "Custom" which is what they truly are and "Standard" seems more "Official" than "Battle" does. If I were in the "Stardard" game mode and searched for Mayflower. I would see a map with the exact same name as the official one. At least this way, it shows there's a difference. |
|
If those names are confusing to you, your solution here actually exacerbates that confusion providing maps from both game modes. |
|
My opinion is that this should not be merged without some sort of toggle on/off. I know for me this feature would annoy me lol. |
Fair enough. That's why I create the PRs, to create the conversation :) |
|
You could consider renaming |
|
I agree with @alexp8, this should be a toggleable functionality. Perhaps you could do it as a settings option. |
Based off devo1929's CnCNet#328. A checkbox is added (unchecked by default). A PR will be created for cncnet-yr-client-package with the layout information.
Based off @devo1929 CnCNet#328. This PR adds a checkbox. Another PR will be made to cncnet-yr-client-package with the layout information.
* Fix incorrect user online private message string Wrong message being displayed in private messages when user comes back online. * Add "search all maps" toggle to game lobby Based off @devo1929 #328. This PR adds a checkbox. Another PR will be made to cncnet-yr-client-package with the layout information. * Revert "Add "search all maps" toggle to game lobby" This reverts commit a33d00b.
* Fix incorrect user online private message string Wrong message being displayed in private messages when user comes back online. * Add "search all maps" toggle to game lobby Based off @devo1929 CnCNet#328. This PR adds a checkbox. Another PR will be made to cncnet-yr-client-package with the layout information. * Revert "Add "search all maps" toggle to game lobby" This reverts commit a33d00b.
