-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added VZNetworkBlockDeviceStorageDeviceAttachment #156
Conversation
@Code-Hex Is the failing CI something I should look into? I couldn't determine whether the cancelled operation was a CI failure, or whether the CI pipeline was externally cancelled. |
virtualization_14.m
Outdated
#ifdef INCLUDE_TARGET_OSX_14 | ||
if (@available(macOS 14, *)) { | ||
NSString *urlNSString = [NSString stringWithUTF8String:uri]; | ||
NSURL *url = [[NSURL alloc] initWithString:urlNSString]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also use NSURL URLWithString:urlNSString
With NSURL alloc
, I believe url
should be in a @autoreleasepool
block or it will leak memory.
No idea if memory needs to be released with URLWithString
, I don't know well enough how objc memory management works :-/
Signed-off-by: Abiola Ibrahim <[email protected]>
add support for nested virtualization
Signed-off-by: Akihiro Suda <[email protected]>
CI: remove old versions and increase timeout
This repo doesn't seem actively maintained currently. Would you be interested in submitting your PR to our fork? https://github.com/lima-vm/vz |
Signed-off-by: Arran Walker <[email protected]>
@AkihiroSuda I invited you to maintain this repo 🙏 |
|
Thanks! |
Further to #142, this adds VZNetworkBlockDeviceStorageDeviceAttachment support.
This PR lacks setting a delegate to monitor state changes to the attachment, mostly because I couldn't figure out the best way to integrate this and it would probably lead to a much larger PR. Hopefully that can be done in a follow-up.
I've updated the MacOS application to ease testing. You can serve an existing raw disk within the bundle directory with
qemu-nbd
:And then run:
The
-install
option also works well with this argument if you serve a disk created withqemu-img
.This is great news as it gives access to
qemu
'sqcow2
format and linked disks functionality.Relates to #143