Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed compile issue on macOS 12 #171

Merged
merged 3 commits into from
Nov 5, 2024
Merged

fixed compile issue on macOS 12 #171

merged 3 commits into from
Nov 5, 2024

Conversation

Code-Hex
Copy link
Owner

@Code-Hex Code-Hex commented Nov 5, 2024

added build stage for macOS 11 and 12

Which issue(s) this PR fixes:

Relate #170

Additional documentation

@Code-Hex Code-Hex requested a review from AkihiroSuda November 5, 2024 01:04
@Code-Hex
Copy link
Owner Author

Code-Hex commented Nov 5, 2024

@Code-Hex Code-Hex marked this pull request as draft November 5, 2024 01:09
@@ -28,6 +28,8 @@ jobs:
fail-fast: false
matrix:
os:
- macos-11 # Intel
- macos-12 # Intel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks information! I didn't know that.
It's tough to lose the means of detecting the problems that occurred this time.

@Code-Hex Code-Hex force-pushed the add/ci-build-check-intel branch from 33c300f to 0965e8e Compare November 5, 2024 02:13
@Code-Hex
Copy link
Owner Author

Code-Hex commented Nov 5, 2024

I confirmed to be compilable on macOS 12

@Code-Hex Code-Hex marked this pull request as ready for review November 5, 2024 02:21
@Code-Hex Code-Hex requested a review from AkihiroSuda November 5, 2024 02:21
@Code-Hex Code-Hex changed the title added macOS 11 and 12 build check in CI fixed compile issue on macOS 12 Nov 5, 2024
@Code-Hex Code-Hex merged commit b32d4ed into main Nov 5, 2024
7 of 8 checks passed
@Code-Hex Code-Hex deleted the add/ci-build-check-intel branch November 5, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants