-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue related to 1.8.8 connections. #741
Conversation
Tested using same proxy, server, and client as #739: |
It looks to be a nice work, I would test it, but building this is pain in the... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully compiled locally on MacOS
AdoptOpenJDK-16.0.1+9
Proxy- Waterfall Build 522.
Backend - 1.12.2, 1.16.5, 1.18.2, 1.20.1, 1.20.2
Tested with clients 1.12.2 Vanilla, 1.12.2 Optifine, 1.20.1 Vanilla, 1.20.2 Vanilla
All load, display server specific and global tab lists and allow gameplay without error
I'm trying to setup this since 2/3 hours, getting different errors, now I'm stuck with: |
I confirm that this patch fixes the problem. Great job man! |
The reality is that most components end up with formatting stuff inside of them, but, I would probably suggest using -1, just for the sake of consistency, unless there is a reason they opted for 0 in the past (which, I doubt, i'd imagine it's pretty much just a case of it having literally 0 impact for the most part) |
Building it with |
Is there any difference in the code behaviour? |
Fixes: #739
Could possibly change the
0
to-1
, but for simplicity sake, it's pretty much how it was before using https://github.com/SpigotMC/BungeeCord/blob/master/protocol/src/main/java/net/md_5/bungee/protocol/Either.java