Support finding and replacing in document #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RayZhao1998 : If enter is not pressed, it does not search for the first occurrence. |
|
Good catch! Just enable |
RayZhao1998
force-pushed
the
feature/finding-in-document
branch
from
6bbdfcd to
f54cd97
Compare
RayZhao1998
changed the title
|
@RayZhao1998 : Ok, now it seems to work. |
RayZhao1998
force-pushed
the
feature/finding-in-document
branch
from
f54cd97 to
1a9f121
Compare
|
I think this PR can be merge now. I'll find out how to customize find bar and make another PR. |
lukepistrol
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just enable
usesFindBarofCodeEditorTextViewto support finding and replacing in a single document.Related Issue
CodeEditApp/CodeEditTextView#31
Checklist
Screenshots