Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live charting in Charter #432

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

KadePleaseHelpMe
Copy link
Contributor

I already made en enhancement issue about this, so I'll copy and paste it here:

Ok so hear me out.
You're trying to make a chart for a song you made, except you decided to make a one-shot mod so your song is like 8 minutes long. Charting usually takes time of song * 185323, so this idea should make charting quicker.

Using a keybind like Ctrl + R, the charter will prompt you to click a strumline to select it for charting. Once selected, you can press space to begin a countdown, starting at the beginning of your chart (Ctrl + Shift + R to start at current position). During this recording, any keybinds that you press will be converted to notes (don't worry, they'll be snapped to whatever grid you set (the one that's 16 by default). Once you press Ctrl + R again, the recording is stopped and you can go in to manually edit whatever charting you didn't like.

Thought it was a cool idea and it would WAY speed up charting. Only problem I can see with this is having input delay, but you can probably easily offset the chart based on Options.songOffset.

@NeeEoo NeeEoo marked this pull request as draft November 5, 2024 16:47
The notes aren't visually appearing for some reason (help)
@KadePleaseHelpMe
Copy link
Contributor Author

Why aren't the notes appearing onscreen
Well I mean they are but like if I just add() instead of notesGroup.add() it doesn't work like a charternote (I've tried so hard to read the api)

totally forgot about this
noticed that it keeps playing (but not recording) after you press accept
probably just a FlxG.pressed thing
I'll try to fix it or I won't
it's not like it's a huge bug, just a little quirk
@NexIsDumb
Copy link
Member

hmm honestly this would be cool actually, just have to check everything in the future

@KadePleaseHelpMe
Copy link
Contributor Author

KadePleaseHelpMe commented Nov 8, 2024

hmm honestly this would be cool actually, just have to check everything in the future

yeah I'm tryna figure out how to properly create and add a charternote
everything else is basically done but the notes are broken=

@KadePleaseHelpMe
Copy link
Contributor Author

@NeeEoo it's not letting me auto-update the stuff how do I make my branch utd

@NeeEoo
Copy link
Member

NeeEoo commented Nov 9, 2024

there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants