Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made combo breaks, actually be combo breaks. #470

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Made combo breaks, actually be combo breaks. #470

wants to merge 9 commits into from

Conversation

rodney528
Copy link
Contributor

No description provided.

@crowplexus
Copy link
Member

that should also reset the combo to 0, not just increase the breaks counter

@rodney528
Copy link
Contributor Author

that should also reset the combo to 0, not just increase the breaks counter

woops

@rodney528
Copy link
Contributor Author

wait

@rodney528
Copy link
Contributor Author

that happens either way

@rodney528
Copy link
Contributor Author

Why do I keep getting a notification for this? Nothings happening.

@PetscopF
Copy link

PetscopF commented Dec 2, 2024

Why do I keep getting a notification for this? Nothings happening.

It's likely a general update, I've been getting notifications where nobody replies as well.

@rodney528
Copy link
Contributor Author

Why do I keep getting a notification for this? Nothings happening.

It's likely a general update, I've been getting notifications where nobody replies as well.

Huh, good to have ig.

@NeeEoo
Copy link
Member

NeeEoo commented Dec 12, 2024

The combo breaks dont break, the combo counter, plus dont they count the same as misses? so why have it seperate?

@PetscopF
Copy link

The combo breaks dont break, the combo counter, plus dont they count the same as misses? so why have it seperate?

I'd say that Combo Breaks are just stricter misses and follow the lines of an FC more.

@rodney528
Copy link
Contributor Author

The combo breaks dont break, the combo counter, plus dont they count the same as misses? so why have it seperate?

Ok, there separate because as you said, there not misses, and fuck.

@rodney528
Copy link
Contributor Author

fixed

@rodney528
Copy link
Contributor Author

rodney528 commented Dec 13, 2024 •
edited
Loading

I swear I am a blind man.

@rodney528 rodney528 requested a review from NeeEoo December 13, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeeEoo NeeEoo Awaiting requested review from NeeEoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodney528 @crowplexus @PetscopF @NeeEoo