-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Collector): Add support to have alternative import column names #37
base: master
Are you sure you want to change the base?
Conversation
f197e6f
to
9f204ea
Compare
(not really a bug, more like a feature IMHO) @piRGoif if the corresponding PR Combodo/iTop#541 would not be accepted, we can reduce this PR to only the addition of protected function HeaderIsAllowed($sHeader)
{
return array_key_exists($sHeader, $this->aFields);
} |
Can I have any feedback please? |
Hello, |
Okay, thanks. I was mentioning you specifically since you added the |
I do some triage but not always very at ease on some subjects O:) |
@Molkobain do you have some (personal?) feedback? |
Not yet unfortunately, as I'm very not familiar with the collectors, I don't know how to test this before / after without a detailled reproduction procedure and test cases. I know the PR template is a bit boring, but it's helps me a lot understanding and setuping the PR to handle it. Otherwise it demands me to spend a few hours to dig into it which I don't have often. :/ |
foreach ($aHeaders as $sHeader) { | ||
if (($sHeader != 'primary_key') && !array_key_exists($sHeader, $this->aFields)) { | ||
if (($sHeader != 'primary_key') && !$this->HeaderIsAllowed($sHeader)) { | ||
if (!$this->AttributeIsOptional($sHeader)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially this part is key to allow for more customisation of the data collectors..
This solves issues when attribute code does not match import column name or if an attribute has multiple columns.
Custom collectors can now override
HeaderIsAllowed
method to specify if the column should be allowed or not.