Handle deprecation of dynamic properties in PHP8.2+

Combodo · Aug 22, 2024 · 8bd53a9 · 8bd53a9
1 parent 1f424c0
commit 8bd53a9
Show file tree

Hide file tree

Showing 4 changed files with 3,642 additions and 3,618 deletions.
diff --git a/library/Vmwarephp/ManagedObject.php b/library/Vmwarephp/ManagedObject.php
@@ -4,6 +4,7 @@
 class ManagedObject {
 	private $reference;
 	protected $vmwareService;
+    private array $aProperties = [];
 
 	function __construct(Service $vmwareService, \ManagedObjectReference $managedObjectReference) {
 		$this->vmwareService = $vmwareService;
@@ -14,17 +15,17 @@ function getParentHost() {
 		return $this->vmwareService->getVhostHost();
 	}
 
-	function __get($propertyName) {
-		if (!isset($this->$propertyName)) {
-			$queryForProperty = 'get' . ucfirst($propertyName);
-			return $this->$queryForProperty();
-		}
-		return $this->$propertyName;
-	}
+    function __get($propertyName) {
+        if (!array_key_exists($propertyName, $this->aProperties)) {
+            $queryForProperty = 'get' . ucfirst($propertyName);
+            return $this->$queryForProperty();
+        }
+        return $this->aProperties[$propertyName];
+    }
 
-	function __set($propertyName, $propertyValue) {
-		$this->$propertyName = $propertyValue;
-	}
+    function __set($propertyName, $propertyValue) {
+        $this->aProperties[$propertyName] = $propertyValue;
+    }
 
 	function getReferenceType() {
 		return $this->reference->type;

diff --git a/library/Vmwarephp/SoapClient.php b/library/Vmwarephp/SoapClient.php
@@ -2,6 +2,15 @@
 namespace Vmwarephp;
 
 class SoapClient extends \SoapClient {
+    private array $aProperties = [];
+
+    public function __set(string $name, mixed $value): void {
+        $this->aProperties[$name] = $value;
+    }
+
+    public function __get(string $name): mixed {
+        return (array_key_exists($name, $this->aProperties) ? $this->aProperties[$name]: null);
+    }
 
 	function __doRequest($request, $location, $action, $version, $one_way = 0) {
 		$request = $this->appendXsiTypeForExtendedDatastructures($request);