Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Added paths value in values.yaml and Service type templating. #109

Closed
wants to merge 3 commits into from

Conversation

diegonayalazo
Copy link

Needed when creating an ingress an missing in the example values.yaml.

Thanks for the project!
Regards,

Diego

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Diego Naya Lazo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@diegonayalazo diegonayalazo changed the title Added paths value in values.yaml. [Helm] Added paths value in values.yaml and Service type templating. Dec 4, 2024
@ibrahimkk-moideen
Copy link
Collaborator

@diegonayalazo Could you sign the CLA when you get a chance.

@diegonayalazo
Copy link
Author

Hi @ibrahimkk-moideen , even though I signed it, it appears unsigned, is there a way to reset it?
image

@derrick-dacosta
Copy link
Collaborator

derrick-dacosta commented Dec 9, 2024

Hi @diegonayalazo what I think is happening is, you signed the CLA through the github GUI which uses a different email address than the one you used to do the commits and PR. This is what I see in your commit logs, scrubbed some of the email as a courtesy.

commit 96bfd73166ca8585a4e77286062d29dd5eeeb67d (HEAD -> main, origin/main, origin/HEAD)
Author: Diego .... <xxxxxxxx>
Date:   .....

    Added a template for choosing the Service type

here is Github's suggestion:

Diego Naya Lazo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@diegonayalazo
Copy link
Author

diegonayalazo commented Dec 9, 2024

Thanks @derrick-dacosta I will start from scratch. Thanks for the email obfucastion. Would you mind deleting my whole email address in the comment even if scrubbed? Much appreciated

@derrick-dacosta
Copy link
Collaborator

Thank you and done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants