-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPE DL360 Gen 10 drive metrics enhancement #32
Merged
derrick-dacosta
merged 11 commits into
Comcast:main
from
jenniferKaiser21:dl360_enhancement
Mar 4, 2024
Merged
HPE DL360 Gen 10 drive metrics enhancement #32
derrick-dacosta
merged 11 commits into
Comcast:main
from
jenniferKaiser21:dl360_enhancement
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrick-dacosta
requested changes
Mar 4, 2024
derrick-dacosta
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for expanding FishyMetrics functionality for HPE ProLiant DL360 Gen10 servers for additional Prometheus drive scrape targets, and resolves the following issue: #31
Notable inclusions are metrics on all drives (NVMe, Logical, and Physical Disk Drives), enhancing the collection of metrics from just the logical drive.
Testing
Tested locally against an inventory of 8 storage and compute specific servers, with configuration that includes multiple Physical Disk Drives, NVMe, and Logical Disk Drives, metrics which are obtained from their respective and differing endpoints.
Elapsed time is reflective of having to collect metrics from multiple additional unique endpoints (due to an increased amount of storage drives in storage configured servers).
Sample result from scraped DL360 server target (in this example, the target server has Physical Disk Drives and a Logical Drive, but no NVMe drive):
Sample from a storage specific server with multiple physical disk drives, NVMe drives, but no logical drive: