-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug CameraView on iOS: camera preview is not always rotated correct and photos are rotated #2312
base: main
Are you sure you want to change the base?
Fix bug CameraView on iOS: camera preview is not always rotated correct and photos are rotated #2312
Conversation
…ct and photos are rotated
@Forestbrook please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
I agree with the CLA. I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Forestbrook Thank you for this. I have added some comments that hopefully you can address but I think the general changes look good
Co-authored-by: Shaun Lawrence <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this myself but the overall changes look good
@Forestbrook @bijington Just as an FYI, we tested this PR in our iOS project and orientation is now working well. Very excited for this to be merged in. |
@tschbc thanks for confirming. I hadn't managed to test this so knowing someone else has really helps. I don't think this will merge before .NET 9.0 support as we are trying to get that in right now. But it'll go in shortly after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this!
@bijington Hey Shawn I have been following this PR and it's of interest to our needs as well. It seems that you approved it, but maybe only SDKs were out of date. What's the process (maybe a time/date?) to getting released. NOTE I am currently getting build errors on the main branch as well as that pr branch. |
@klindberg-magaya we are still trying to get the .NET 9.0 PR merged and then get all of these other bits in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Description of Change
The Camera preview was not always correct because UIDevice.CurrentDevice.Orientation does not always return the correct rotation.
The photos were shown rotated, because the VideoOrientation of the AVCapturePhotoOutput connection was not set when taking a picture.
Linked Issues
#2311 [BUG] CameraView on iOS: camera preview is not always rotated correct and photos are rotated
Fixes:
Could not add tests because CameraManager.macios.cs is internal and the changes are iOS specific.
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PR