Convert to_json to as_json to follow Ruby/Rails convention #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently we are using
to_json
to render theJsonRenderable
class to a Hash representation of the object (useful for storing in the DB for example). That doesn't follow the convention though whereto_json
should return the JSON string representation of the object. Instead we should be usingas_json
orto_h
. I opted to implementas_json
and aliasto_h
to that method.