Skip to content

Commit

Permalink
Merge pull request #127 from Concordium/fix-doc-warnings
Browse files Browse the repository at this point in the history
Fix doc warnings and add lint
  • Loading branch information
lassemoldrup authored Sep 27, 2023
2 parents 1462970 + c161fed commit 8366c38
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 3 deletions.
23 changes: 22 additions & 1 deletion .github/workflows/build-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,28 @@ jobs:
run: |
cargo fmt -- --color=always --check
"lint_doc":
name: lint:doc
# Don't run on draft pull requests
if: ${{ !github.event.pull_request.draft }}
runs-on: ubuntu-latest
steps:
- name: Install protobuf
run: sudo apt-get install -y protobuf-compiler
- name: Checkout
uses: actions/checkout@v2
with:
submodules: recursive
- name: Install Rust
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: ${{ env.RUST_VERSION }}
override: true
- name: Docs
run: |
RUSTDOCFLAGS="-D warnings" cargo doc --no-deps --all-features --color=always
"lint_clippy":
name: lint:clippy
# Don't run on draft pull requests
Expand Down Expand Up @@ -78,4 +100,3 @@ jobs:
components: rustfmt
- name: Test
run: cargo test

7 changes: 5 additions & 2 deletions src/v2/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2337,8 +2337,11 @@ impl Client {
})
}

/// For a non-genesis block, this returns the [`QuorumCertificate`], a
/// [`TimeoutCertificate`] (if present) and [`EpochFinalizationEntry`] (if
/// For a non-genesis block, this returns the
/// [`QuorumCertificate`](block_certificates::QuorumCertificate), a
/// [`TimeoutCertificate`](block_certificates::TimeoutCertificate) (if
/// present)
/// and [`EpochFinalizationEntry`](block_certificates::EpochFinalizationEntry) (if
/// present).
/// If the block being pointed to is *not* from protocol version 6 or
/// above, then [`InvalidArgument`](`tonic::Code::InvalidArgument`)
Expand Down

0 comments on commit 8366c38

Please sign in to comment.