Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lq all in 1 #565

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Lq all in 1 #565

wants to merge 3 commits into from

Conversation

lorenaqendro
Copy link
Contributor

@lorenaqendro lorenaqendro commented May 29, 2018

Description

Incorporated in the repo the python support and qgis plugin.

Checklist

  • Created new test(s) (if applicable)
  • Updated the README / documentation (if applicable)

Copy link
Contributor

@arya-hemanshu arya-hemanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by cloning the branch, and it works fine. Tested building DC and running some recipes. Also tested running some python recipes and they also worked fine.

Looks good to me. Once @thanosbnt review is done, i think it is good to merge

@thanosbnt
Copy link
Contributor

I'm not sure if this works with qgis as i have to place the plugin at a specific directory...This means cloning the whole repo in the qgis folder, locating the plugin and copying over to the right directory. Not sure how i could do it...

@lorenaqendro
Copy link
Contributor Author

@thanosbnt do you think a symlink to the qgis plugin on the repo would do?

@thanosbnt
Copy link
Contributor

Never used this, we could try it out

@lorenaqendro
Copy link
Contributor Author

Yes, let's try together tomorrow and see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants