Better distinguish between durable and non-durable proof goals. Refs #51. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. Previously, the verifier was inconsistent about whether it would log certain types of proof goals. As discussed in #51, there are really two types of proof goals: 1. Goals that the verifier asserts directly as part of the correspondence proof. 2. Goals that arise during symbolic execution of the `step()` function to ensure memory safety. We always want to log goals of type (1), as they are core to the correspondence proof that the verifier is computing. Due to the sheer volume of goals of type (2), however, we only want to log type-(2) goals if they are non-trivial (i.e., not just the `true` predicate in `what4`). This patch: * Ensures that all type-(1) goals are asserting using Crucible's _durable_ assertions so that they will always be logged, even if they are trivial. * Makes the verifier's logs distinguish between the two types of goals when the `Noisy` verbosity level is chosen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the verifier was inconsistent about whether it would log certain types of proof goals. As discussed in #51, there are really two types of proof goals:
step()function to ensure memory safety.We always want to log goals of type (1), as they are core to the correspondence proof that the verifier is computing. Due to the sheer volume of goals of type (2), however, we only want to log type-(2) goals if they are non-trivial (i.e., not just the
truepredicate inwhat4).This patch:
Noisyverbosity level is chosen.Fixes #51.