Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflows #1470

Merged
merged 27 commits into from
Mar 5, 2024
Merged

GitHub Workflows #1470

merged 27 commits into from
Mar 5, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Mar 5, 2024

  • build and run counterparty-lib tests on Macos (x86_64 and M1) and Ubuntu
  • Bandit
  • CodeQL
  • Pylint
  • License Scanner

@adamkrellenstein
Copy link
Member

So happy to see this finally! 🥰

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ouziel-slama ouziel-slama changed the title [WIP] GitHub Workflow GitHub Workflows Mar 5, 2024
import json

# pylint: disable=no-name-in-module
from sh import license_scanner

Check warning

Code scanning / pylint

Unable to import 'sh'. Warning

Unable to import 'sh'.
def test_b58_check_decode():

return b58.b58_decode(encoded, version)
pass

Check warning

Code scanning / pylint

Final newline missing. Warning test

Final newline missing.
@@ -1,5 +1,5 @@
from counterparty_rs import b58

# TODO

Check warning

Code scanning / pylint

TODO. Warning test

TODO.
Copy link
Member

@adamkrellenstein adamkrellenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️❤️❤️

@ouziel-slama ouziel-slama merged commit 61b42aa into develop Mar 5, 2024
12 checks passed
@ouziel-slama ouziel-slama deleted the github branch March 5, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants