Check Sighash Flag #2807
Check Sighash Flag #2807
Conversation
ouziel-slama
commented
Dec 7, 2024
•
ouziel-slama
commented
- Double-check the spelling and grammar of all strings, code comments, etc.
- Double-check that all code is deterministic that needs to be
- Add tests to cover any new or revised logic
- Ensure that the test suite passes
- Update the project release notes
- Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if util.is_utxo_format(message_data["source"]): | ||
| return "detach" | ||
| return "attach" | ||
| except Exception: |
Check warning
Code scanning / pylint
Catching too general exception Exception. Warning
Fix ParentProcessChecker Thread
| logger.info("API Server stopped.") | ||
|
|
||
|
|
||
| def is_process_alive(pid): | ||
| """Check For the existence of a unix pid.""" | ||
| try: |
Check warning
Code scanning / pylint
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it. Warning
| @@ -2163,7 +2163,7 @@ | |||
| return holders | |||
|
|
|||
|
|
|||
| def holders(db, asset, exclude_empty_holders=False): | |||
| def holders(db, asset, exclude_empty_holders=False, block_index=None): | |||
Check warning
Code scanning / pylint
Unused argument 'block_index'. Warning
| @@ -155,11 +157,152 @@ | |||
| return vout["value"], vout["script_pub_key"], is_segwit | |||
|
|
|||
|
|
|||
| def is_valid_der(der): | |||
Check warning
Code scanning / pylint
Too many return statements (8/6). Warning
| if len(der) != 6 + rlength + slength: | ||
| return False | ||
| return True | ||
| except Exception: |
Check warning
Code scanning / pylint
Catching too general exception Exception. Warning
| try: | ||
| r = int.from_bytes(schnorr[0:32], byteorder="big") | ||
| s = int.from_bytes(schnorr[32:64], byteorder="big") | ||
| except Exception: |
Check warning
Code scanning / pylint
Catching too general exception Exception. Warning
| return None | ||
|
|
||
|
|
||
| def get_schnorr_signature_sighash_flag(value): |
Check warning
Code scanning / pylint
Either all return statements in a function should return an expression, or none of them should. Warning
