Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Tweaks #2859

Merged
merged 5 commits into from
Dec 17, 2024
Merged

API Tweaks #2859

merged 5 commits into from
Dec 17, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Dec 17, 2024

  • Add give_asset and get_asset parameters for get orders by asset endpoint
  • Add forward_asset and backward_asset parameters for get order matches by asset endpoint
  • Add forward_price and backward_price in order matches results

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft December 17, 2024 08:07
@@ -2687,6 +2687,8 @@
state_db,
asset: str,
status: OrderStatus = "all",
get_asset: str = None,

Check warning

Code scanning / pylint

Redefining name 'get_asset' from outer scope (line 2362). Warning

Redefining name 'get_asset' from outer scope (line 2362).
@ouziel-slama ouziel-slama force-pushed the apitweaks branch 2 times, most recently from 93a947b to f8604f1 Compare December 17, 2024 11:47
@ouziel-slama ouziel-slama merged commit 4f6b5b1 into develop Dec 17, 2024
18 checks passed
@ouziel-slama ouziel-slama deleted the apitweaks branch December 17, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants