Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verbose=True when give_asset or get_asset contain an asset_longname #2886

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Dec 25, 2024

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

Copy link
Member

@adamkrellenstein adamkrellenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix! let's just add a test for this

@ouziel-slama
Copy link
Contributor Author

good fix! let's just add a test for this

don't have a test suite adapted for this test. Added this issue: #2887

@ouziel-slama ouziel-slama merged commit 0be5cd9 into develop Dec 25, 2024
19 checks passed
@ouziel-slama ouziel-slama deleted the fixes branch December 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants