Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model chunking support #404

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Conversation

billschereriii
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #404 (cbf3703) into develop (faf58b3) will decrease coverage by 0.15%.
The diff coverage is 66.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #404      +/-   ##
===========================================
- Coverage    78.34%   78.20%   -0.15%     
===========================================
  Files           97       97              
  Lines         7070     7179     +109     
===========================================
+ Hits          5539     5614      +75     
- Misses        1531     1565      +34     
Files Coverage Δ
include/client.h 100.00% <ø> (ø)
include/command.h 100.00% <100.00%> (ø)
include/commandreply.h 100.00% <100.00%> (ø)
include/redisserver.h 60.00% <100.00%> (+60.00%) ⬆️
src/cpp/redisserver.cpp 98.80% <100.00%> (+0.01%) ⬆️
src/python/bindings/bind.cpp 87.67% <100.00%> (+0.08%) ⬆️
src/python/module/smartredis/client.py 95.75% <100.00%> (+0.04%) ⬆️
src/python/src/pyclient.cpp 76.53% <100.00%> (+0.26%) ⬆️
src/cpp/client.cpp 88.07% <74.41%> (-0.52%) ⬇️
src/cpp/redis.cpp 52.70% <52.17%> (+0.49%) ⬆️
... and 1 more

@billschereriii billschereriii self-assigned this Sep 26, 2023
@billschereriii billschereriii added type: feature Issues that include feature request or feature idea area: test Issues related to the test suite area: python Issues related to the Python Client area: C++ Issues related to the C++ client labels Sep 26, 2023
@billschereriii billschereriii marked this pull request as ready for review September 26, 2023 20:51
Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about adding in the units. Also as we agree offline, in the documentation please mention that setting the chunksize is generally not needed, even by advanced users; instead highlight that now we support users uploading models >=512MB.

include/client.h Outdated Show resolved Hide resolved
include/pyclient.h Outdated Show resolved Hide resolved
include/redisserver.h Outdated Show resolved Hide resolved
@billschereriii billschereriii merged commit 53def75 into CrayLabs:develop Sep 28, 2023
@billschereriii billschereriii deleted the chunky branch September 28, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: C++ Issues related to the C++ client area: python Issues related to the Python Client area: test Issues related to the test suite type: feature Issues that include feature request or feature idea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants