-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.6.0 #510
Merged
Release v0.6.0 #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into develop
The new major version release of Numpy is incompatible with modules compiled against Numpy 1.x. For both SmartSim and SmartRedis we request a 1.x version of numpy. This is needed in SmartSim because some of the downstream dependencies request NumPy. [ committed by @ashao ] [ reviewed by @al-rigazzi ]
This PR will remove 3 broken links to `oss.redis.com` that are breaking the documentation build [ committed by @ankona ] [ approved by @MattToast ]
Previously we were using a Makefile to download and install third-party dependencies for the library compilation (hiredis, redis++, and PyBind). This PR migrates this functionality to the `CMakeLists.txt` by adding hiredis and redis++ as `ExternalProject`s and by using cmake to download the pybind headers. Additionally, to further ease integration into existing CMake-based projects the build system now creates CMakeConfig files for SmartRedis. Lastly, the testing harness and build of the examples were also updated to take advantage of these improvements as well. [ committed by @ashao ] [ reviewed by @mellis13 ]
Touch-up some outdated information in the SmartRedis README.md [ committed by @ashao ] [ reviewed by @amandarichardsonn ]
This PR fixes a compilation error that will occur with gcc-14. Gcc-14 was not added to the testing infrastructure, and as a result, gcc-14 is not officially supported. [ committed by @mellis13 ] [ reviewed by @al-rigazzi ]
Update version number to 0.6.0 for release. [ committed by @MattToast ] [ reviewed by @al-rigazzi ]
al-rigazzi
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -88,6 +88,6 @@ jobs: | |||
- name: Build wheels | |||
run: python -m cibuildwheel --output-dir wheelhouse | |||
|
|||
- uses: actions/upload-artifact@v2 | |||
- uses: actions/upload-artifact@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All for the sake of progress!
Changes that need to be made to our release pipeline before we can release SmartRedis v0.6.0. [ committed by @MattToast ] [ reviewed by @al-rigazzi ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge develop to master for release (second time's a charm!)