Reenable move semantics and suppress warnings #520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two small changes to the SmartRedis code:
std::random_device
instance is not stored as a member variable on theRedisServer
class. Thestd::random_device
is not movable or copyable, and as a result, it was implicitly disabling move semantics for theClient
and theRedisServer
derivates.Exception
class methods have been marked with the appropriateconst override
keywords to suppress compiler warnings.