Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #522

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix lint errors #522

merged 2 commits into from
Nov 1, 2024

Conversation

mellis13
Copy link
Collaborator

This PR fixes lint issues so that other large PRs are less difficult to review.

@mellis13 mellis13 requested review from ashao and al-rigazzi October 31, 2024 23:28
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.62%. Comparing base (4937fbd) to head (ede6e59).
Report is 16 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #522       +/-   ##
============================================
- Coverage    95.92%   57.62%   -38.31%     
============================================
  Files           10      147      +137     
  Lines          884    11708    +10824     
  Branches         0     1121     +1121     
============================================
+ Hits           848     6747     +5899     
- Misses          36     4810     +4774     
- Partials         0      151      +151     
Files with missing lines Coverage Δ
src/python/module/smartredis/client.py 97.55% <100.00%> (ø)
src/python/module/smartredis/configoptions.py 92.68% <ø> (ø)
src/python/module/smartredis/dataset_utils.py 96.55% <ø> (ø)
src/python/module/smartredis/util.py 93.10% <100.00%> (ø)

... and 137 files with indirect coverage changes

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, isolating this in its own PR was definitely a good idea

@mellis13 mellis13 merged commit bc6e9d4 into CrayLabs:develop Nov 1, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants