Remove redundant count condition

Crown-Commercial-Service · Oct 10, 2024 · d2914e2 · d2914e2
1 parent 8c14231
commit d2914e2
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 11 deletions.
diff --git a/modules/postgres-etl/load/load_sfn.tf b/modules/postgres-etl/load/load_sfn.tf
@@ -1,5 +1,4 @@
 resource "aws_sfn_state_machine" "s3_to_rds" {
-  count = var.environment_name == "production" ? 0 : 1 # This state machine is skipped in production
 
   name     = "postgres-etl-s3-to-rds"
   role_arn = aws_iam_role.s3_to_rds_sfn.arn
@@ -53,7 +52,6 @@ EOF
 }
 
 resource "aws_iam_role" "s3_to_rds_sfn" {
-  count = var.environment_name == "production" ? 0 : 1 # This role is skipped in production
 
   name = "${var.migrator_name}_s3_to_rds_sfn"
 
@@ -77,7 +75,6 @@ resource "aws_iam_role" "s3_to_rds_sfn" {
 }
 
 data "aws_iam_policy_document" "s3_to_rds_sfn" {
-  count = var.environment_name == "production" ? 0 : 1 # This policy is skipped in production
 
   version = "2012-10-17"
 
@@ -143,8 +140,6 @@ data "aws_iam_policy_document" "s3_to_rds_sfn" {
 }
 
 resource "aws_iam_role_policy" "s3_to_rds_sfn" {
-  count = var.environment_name == "production" ? 0 : 1 # This policy is skipped in production
-
   role   = aws_iam_role.s3_to_rds_sfn.name
   policy = data.aws_iam_policy_document.s3_to_rds_sfn.json
 }
diff --git a/modules/postgres-etl/load/load_sg.tf b/modules/postgres-etl/load/load_sg.tf
@@ -1,6 +1,4 @@
 resource "aws_security_group" "etl_load_task" {
-  count = var.environment_name == "production" ? 0 : 1 # Don't create for production
-
   name        = "${var.resource_name_prefixes.normal}:${upper(var.migrator_name)}:ECSTASK:LOAD"
   description = "PG ETL Load task"
   vpc_id      = var.vpc_id
@@ -11,8 +9,6 @@ resource "aws_security_group" "etl_load_task" {
 }
 
 resource "aws_security_group_rule" "etl_load_task_https_out_anywhere" {
-  count = var.environment_name == "production" ? 0 : 1 # Don't create for production
-
   cidr_blocks       = ["0.0.0.0/0"]
   description       = "Allow https out from load task to anywhere"
   from_port         = 443

diff --git a/modules/postgres-etl/load/load_task.tf b/modules/postgres-etl/load/load_task.tf
@@ -1,8 +1,6 @@
 module "load_task" {
   source = "../../../resource-groups/ecs-fargate-task-definition"
 
-  count = var.environment_name == "production" ? 0 : 1 # Don't create the load task in production
-
   aws_account_id = var.aws_account_id
   aws_region     = var.aws_region
   container_definitions = {