Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earthdata Cloud tutorial for 2023 AGU Fall Meeting Workshop #81

Merged
merged 15 commits into from
Dec 7, 2023

Conversation

JessicaS11
Copy link
Contributor

No description provided.

@asteiker
Copy link
Contributor

asteiker commented Dec 5, 2023

@JessicaS11 Thank you for your comments - I addressed those in both the intro and earthdata search markdown files. I also re-tested the earthaccess and icepyx tutorials since the image was updated, and removed the manual pip install of the latest icepyx. I think things are in a pretty solid state other than considering if/what to cut. We could also consider keeping this content for reference but skipping or only briefly covering portions (like details on ICESat-2 mission, earthdata search intro) to keep within time.

@JessicaS11 JessicaS11 marked this pull request as ready for review December 7, 2023 15:45
@JessicaS11 JessicaS11 requested a review from asteiker December 7, 2023 15:47
Copy link
Member

@tsnow03 tsnow03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. My only comment is that if you have a chance to change to color blind friendly colors on your red/green/blue plots, that would be awesome.

@tsnow03
Copy link
Member

tsnow03 commented Dec 7, 2023

How do you want me to add this to our JupyterBook table of contents? As 5 tutorials?

@asteiker
Copy link
Contributor

asteiker commented Dec 7, 2023

@tsnow03 We did have one plot with red/green/blue which I updated to a more color-friendly palette. There is another plot with that color scheme which is an image from a publication that I can't change.

I also updated earthaccess from 0.8.1 to 0.8.2 so if you could update the image once again for CryoCloud I would greatly appreciate that!

And if you are able to keep the file structure here: (Tutorials/NASA-Earthdata-Cloud-Access/1. … 4. ) that would be ideal but otherwise we could collapse at the higher Tutorials level. If we need to go with the latter, then we may want to update the names to something like "Cloud_Access_1:Intro-Earthdata-Cloud.md", "Cloud_Access_2: earthdata_search.md" so that the numbers aren't out of context with the other tutorials.

@asteiker asteiker merged commit 002e172 into main Dec 7, 2023
2 checks passed
@asteiker asteiker deleted the earthdata-cloud branch December 7, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants