Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Initial commit to add automatic pool sizing #15

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Happyrobot33
Copy link

@Happyrobot33 Happyrobot33 commented Oct 17, 2023

Well ive tried my best to cover all edge cases, even though it is still possible for it to miss auto sizing.
closes #14
closes #12

It will check the pool size if you look at the inspector, focus the SDK, or have a script rebuild / import. This should hopefully cover enough things that its not an issue over the long run. The only thing it does not cover is if the user changes the world size through the SDK and saves it, then immediately builds. This is because without using harmony to edit those methods theres not really anything to hook onto to detect that change unfortunately. I also realize this code is a bit..... jank, so if you have any ideas on how to clean it up or want to remove things let me know

@Happyrobot33 Happyrobot33 marked this pull request as draft February 5, 2024 03:57
@Happyrobot33
Copy link
Author

Converted to draft, still encountering issues in prod in openflight, so its not perfect and ready for use

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlayerObjectPool not automatically created if inspector isnt shown Automate pool size using VRCWorld
1 participant