Fixes issues with trimComponents #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseCrusher
force-pushed
the
bugfix/trimComponents-trims-to-much
branch
from
570d1af to
3d51c2e
Compare
|
Thank you so much! This looks good to me. @cerrussell, any thoughts? |
Signed-off-by: BaseCrusher <[email protected]>
Signed-off-by: BaseCrusher <[email protected]>
BaseCrusher
force-pushed
the
bugfix/trimComponents-trims-to-much
branch
from
37d219e to
e4be5e8
Compare
|
I needed to add an additional check if the packages do not have a version which can happen in dotnet. |
prabhu
reviewed
Oct 5, 2023
|
To fix the prettier error, please install prettier-cli globally and run |
Signed-off-by: BaseCrusher <[email protected]>
prabhu
reviewed
Oct 5, 2023
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the upgrade to CycloneDX Version 1.5 there has been a regression where the dotnet packages did not resolve correctly for dotnet framework projects. This fixes this issue.
The issue came up because
trimComponentswas called on the package list before the SBoM is created. Because of this all the package objects in the package list do not have one of the required keyspurlorbom-ref. This led to the key being undefined for all packages where when checking if there is already a package with the same key in thekeyCachewas alwaystrue.The fix was implemented by adding an additional fallback value by concatenating the
nameandversionof the package object.