Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of strings.xml in Portuguese (BR) #786

Merged
merged 5 commits into from
May 1, 2019

Conversation

thezakman
Copy link
Contributor

Describe the pull request

Portuguese (Brazilian) translation of strings.

Link to relevant issues

Issue #430 Translations needed

@thezakman
Copy link
Contributor Author

#430 (comment)

@thezakman thezakman changed the title Add files via upload Translation of strings.xml in Portuguese (BR) Apr 24, 2019
@corbinlc
Copy link
Member

@thezakman Please notice this error in the build log:

> Task :app:mergeDebugResources FAILED
/home/circleci/workspace/app/src/main/res/values-pt-BR: Error: Invalid resource directory name

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:mergeDebugResources'.
> /home/circleci/workspace/app/src/main/res/values-pt-BR: Error: Invalid resource directory name

@corbinlc
Copy link
Member

Probably want, values-pt-rBR instead of values-pt-BR. Please try that out.

@thezakman
Copy link
Contributor Author

Ok, ill push it now.

@thezakman
Copy link
Contributor Author

@corbinlc still got error with "values-pt-rBR"

@thezakman thezakman closed this Apr 29, 2019
@corbinlc corbinlc reopened this Apr 29, 2019
@thezakman thezakman closed this Apr 29, 2019
@thezakman thezakman reopened this Apr 29, 2019
@corbinlc
Copy link
Member

The error is different this time. You now have the filed named correctly.

> Task :app:mergeDebugResources FAILED
/home/circleci/workspace/app/src/main/res/values-pt-rBR/strings.xml:61:39: Error: Element type "string" must be followed by either attribute specifications, ">" or "/>".

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:mergeDebugResources'.
> /home/circleci/workspace/app/src/main/res/values-pt-rBR/strings.xml:61:39: Error: Element type "string" must be followed by either attribute specifications, ">" or "/>".

@corbinlc
Copy link
Member

You have a syntax issue on line 61

@corbinlc
Copy link
Member

corbinlc commented Apr 29, 2019

<string name="illegal_state_title"UserLAnd entrou em um estado ilegal!</string>
should probably be
<string name="illegal_state_title">UserLAnd entrou em um estado ilegal!</string>

@corbinlc
Copy link
Member

Please click on a failing build where it says "Details" to see the same errors I am seeing.

@thezakman
Copy link
Contributor Author

@corbinlc my bad, that is true.
Will fix it now.

@thezakman
Copy link
Contributor Author

Done ;)

@corbinlc
Copy link
Member

Do you think this translation would work pretty well for Portuguese speakers in other places outside of Brazil?

@thezakman
Copy link
Contributor Author

@ corbinlc, will work 90% since European Portuguese (Portugal) differs somewhat from ours (not much though).

@corbinlc
Copy link
Member

I was just thinking we could make this the values-pt file instead of the values-pt-rBR file and help people outside of Brazil too. Then, we would only create a values-pt-r* for differences that people flag. What do you think?

@thezakman
Copy link
Contributor Author

It is better to keep European Portuguese as a standard and use values-pt-rBR ​​for Brazilians, since it is used not only in Portugal but also in other countries in Africa.

@corbinlc
Copy link
Member

We just don't have any European Portuguese translation so far.

@thezakman
Copy link
Contributor Author

So if you think would be better to keep this format, go for it :)

Copy link
Member

@corbinlc corbinlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now. Obrigado.

@corbinlc corbinlc merged commit 52a648b into CypherpunkArmory:master May 1, 2019
@corbinlc
Copy link
Member

corbinlc commented May 1, 2019

This will go out in our next release.

@thezakman
Copy link
Contributor Author

No problem man, i'm glad I could help.
Cheers!

MatthewTighe pushed a commit that referenced this pull request Aug 14, 2019
* Add files via upload

* Translation of strings.xml in Portuguese (BR)

* Delete strings.xml

* Add files via upload

* Fixed syntax error
@hugok79
Copy link

hugok79 commented May 9, 2022

We just don't have any European Portuguese translation so far.

@corbinlc I can help with the European Portuguese translation. (pt, pt_PT)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants