Use aspect maps and add ability to use alternate light config (#422) #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#422) Idea to use a map to control the pins set for the different signal aspects, instead of just straight RED->redpin, AMBER->amberpin, GREEN->greenpin. There is a main map which does this and then an alternate map which may do anything. In the example, we use red -> amber/green -> green, which is the Deutsche Bahn signalling resolution (where physical signals are used rather than in-cab). This rewrites the LED section of the RMFT2::doSignal(), making it use the aspect map for even the features of merging red and green together for amber and the high-is-off setting. It adds 2 new automations: SIGNALA and SIGNALAH to allow the use of the alternate maps.
|
Hi Maintainers, please note this is a work in progress and hasn't actually been tested as per the issue it references (#422). I'm mostly interested in what you think of it at this stage - am I barking up the wrong tree? |
Asbelos
requested changes
Oct 1, 2024
There was a problem hiding this comment.
This is, I think, a welcome change.
However the doSignal code has recently been rewritten to provide for additional signal types such as neopixels. This makes it much easier to expand but means that this PR will not merge to the latest development branches.
Author, please take a look at the latest signal code and discuss with me (UKBloke,) on discord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea to use a map to control the pins set for the different signal aspects, instead of just straight RED->redpin, AMBER->amberpin, GREEN->greenpin. There is a main map which does this and then an alternate map which may do anything. In the example, we use red -> amber/green -> green, which is the Deutsche Bahn signalling resolution (where physical signals are used rather than in-cab).
This rewrites the LED section of the RMFT2::doSignal(), making it use the aspect map for even the features of merging red and green together for amber and the high-is-off setting. It adds 2 new automations: SIGNALA and SIGNALAH to allow the use of the alternate maps.