Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARA-52 토스트메시지 전역 객체로 변경 #11

Merged
merged 11 commits into from
Feb 5, 2024
Merged

MARA-52 토스트메시지 전역 객체로 변경 #11

merged 11 commits into from
Feb 5, 2024

Conversation

a-honey
Copy link
Member

@a-honey a-honey commented Feb 2, 2024

요구사항

이슈번호: Mara-52

작업내용

  • 토스트 메시지 컴포넌트 전역 변경(src/template/Layout.tsx)
  • 토스트 메시지 타입별 스토리 작성

테스트 결과 또는 방법

image

@a-honey a-honey added the enhancement New feature or request label Feb 2, 2024
Copy link
Member

@choipureum choipureum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

토스트 고생하셧슴당!
해당 리뷰만 반영 부탁드립니당😀

@a-honey
Copy link
Member Author

a-honey commented Feb 4, 2024

토스트 고생하셧슴당! 해당 리뷰만 반영 부탁드립니당😀

hook 추가했습니다 🌸🌸
id로 시간초과 후 hook에서 삭제하도록 수정했습니당

src/hooks/useToast.ts Outdated Show resolved Hide resolved
src/hooks/useToast.ts Outdated Show resolved Hide resolved
Copy link
Member

@choipureum choipureum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 바로 반영 감사합니다! 훨씬 사용성 높아졌네용 수고하셨습니다🙇‍♂️

@a-honey a-honey merged commit 4c953e6 into main Feb 5, 2024
1 check passed
@a-honey a-honey deleted the MARA-52 branch February 5, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants