Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ManuScript code that does not work any more #124

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

th-we
Copy link

@th-we th-we commented May 16, 2021

This unused code won't work any more because the surrounding code has evolved away from it. Specifically, MEIFlattened is no longer a SparseArray and can not be used in the way these function use it.

@th-we
Copy link
Author

th-we commented Aug 23, 2021

@ahankinson Can we merge this? To sum up the changes:

  • getPositionInDocument() and lookBack() were removed. They do not work any more because they assume the global MEIFlattened is a SparseArray, but it's not a Dictionary. They are not used anyway in either libmei.plg or sibmei.
  • XML parser is "parked" in a separate Python variable, documenting the state of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant