Manuscript fixes #125
Open
Manuscript fixes #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on and writing failed
Previously, this was only the case for self-closing elements
|
@ahankinson Added the same commit as in the sibmei repo. Overall this pull request is to bring libmei back in sync with the version shipping with ManuScript. |
ahankinson
reviewed
Aug 24, 2021
tools/langs/manuscript.py
Outdated
| element._id = value; | ||
| SetId "(element, newId) { | ||
| UnregisterId(element._id); | ||
| element._id = value; |
There was a problem hiding this comment.
Same problem here as in the sibmei repo -- I think value is supposed to be newId?
ahankinson
reviewed
Aug 24, 2021
tools/langs/manuscript.py
Outdated
| }" | ||
| UnregisterId "(id) { | ||
| olddict = Self._property:MEIFlattened; | ||
| newdict = removeKeyFromDictionary(olddict, oldid); |
There was a problem hiding this comment.
And here isn't oldid supposed to be the value passed in, id?
There was a problem hiding this comment.
That's right. I made sure I unloaded/reloaded the proper files in Sibelius and ran the tests successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A replacement for #119 with better organized commits.