[CORE] Improvements, Changes and Fixes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C, returning an array returns a pointer to the first element, which will be on the stack in this case. As there's no guarantee that local data on the stack survives after returning from a function, this is dangerous. Making the variable static to make it survive past the function lifetime.
* Added support to compile on Windows + MSYS2 (WIP) * Modified BITMAP and RGBQUAD struct names to avoid conflict with wingdi.h struct on windows
* Convert codebase from CP850 charset to UTF8
…IVGAMES#15) When converting to UTF8, some characters now no longer fit in 1 byte. Use the actual original (CP850 charset) value of those characters instead
- [INSTALLER] fixed bug of buffer overflow in packager installer not allowing to save properly large file names on modern platforms - [INSTALLER] fixed bug not including some libraries needs to windows executable
[IDE - INSTALLER] Fixes
* [CORE] Changed - all files except divc.c, and divforma.c are now better formatted. * [CORE] Changed - saved all source files with UTF-8 encoding * [CORE] Changed - mnemonics opcodes from "lname" to "DIVBC_name" to avoid compile error or conflicts in modern compilers/libraries (especially on Windows) * [CORE] Changed - homogenization of all definitions/declarations of structures with "_t_name" and "t_name" prefixes * [CORE] Changed - improved all DIV function names with "DIV" prefix [CicTec] * [CORE] Changed - improved all mode8 internal function names with "m8" prefix [CicTec] * [CORE] Changed - improved all audio internal function names with "DIV" prefix [CicTec] * [CORE] Changed - improved all flic internal function names with "DIV" prefix [CicTec] * [RUNTIME] Fixed - bug potential memory leaks generated when program ends after an internal "e" or "exer" function call * [RUNTIME] Fixed - bug memory alloc check for VideoMode Setting * [RUNTIME] Fixed - bug memory alloc check for VideoMode RGB surface creation * [RUNTIME] Fixed - bug memory alloc check for VideoMode Setting on UpdateRect * [LIBRARY] Fixed - bug check file opening success to avoid crash saving PCX * [RUNTIME] Fixed - [PSP] bug check file opening success to avoid crash saving * [RUNTIME] Fixed - bug in mismatching data causing big data memory allocation in release version of programs and other errors * [RUNTIME] Fixed - bug of type declaration on function stack-system [CicTec] * [RUNTIME] Fixed - bug potential memory leak when an user uses DIV MALLOC function without corresponding FREE function before the program ends * [LIBRARY] Fixed - bug memory alloc check in LOAD_MAP function * [LIBRARY] Fixed - bug memory leaks in LOAD_MAP function loading PCX in non pack-file * [LIBRARY] Fixed - bug memory leak in LOAD_MAP function when try loading not a valid MAP * [LIBRARY] Fixed - bug potential memory leaks in LOAD_FPG function loading FPG in non pack-file * [LIBRARY] Fixed - bug memory alloc check in LOAD_FPG function for EMSCRIPTEN version * [LIBRARY] Fixed - bug memory leak in STOP_SCROLL function * [LIBRARY] Fixed - bug memory leak in LOAD_FNT function loading FNT in non pack-file * [LIBRARY] Fixed - bug in SET_MODE function to stop/reset correctly the mode7 windows activated * [LIBRARY] Fixed - bug in FRAME_FLI function avoiding crash when is called without FLI/FLC built support * [LIBRARY] Fixed - bug in PLAY_CD function to check properly the param value passed to function avoid stopping the currently CD playing if new call fails * [LIBRARY] Fixed - bug not updating the EXIT function STRING message in DEBUG version * [LIBRARY] Fixed - bug in STOP_SCROLL function not updating correctly internal variables, causing possible crash when the program ends * [LIBRARY] Fixed - bug in UNLOAD_MAP function introduced in previous update, not unloading corretly memory maps allocated by the LOAD_MAP, LOAD_PCX, NEW_MAP and WRITE_IN_MAP functions, causing memory leaks * [RUNTIME] Fixed - bug memory leak when an user uses DIV LOAD_MAP, LOAD_PCX, NEW_MAP and WRITE_IN_MAP functions not unloading its allocated resources corretly when the program ends causing also possible crash * [RUNTIME] Fixed - bug potential memory leak when an user uses DIV LOAD_FNT(S) function(s) without corresponding UNLOAD_FNT(S) function(s) before the program ends * [RUNTIME] Fixed - bug potential memory leak when an user uses more concurrent DIV LOAD_FPG(S) function(s) without corresponding UNLOAD_FPG(S) function(s) before the program ends * [RUNTIME] Fixed - bug memory leak when an user uses DIV mode8 not unloading its allocated resources when the program ends * [RENDERER] Fixed - bug causing black screen and erroneous size when program window is maximized and switch back to normal * [RUNTIME] Fixed - bug calling finalization function twice during end of program causing possible crash sometimes
[CORE] improvements, changes and fixes
* [RUNTIME] Fixed - bug to unable to impot DLL with import statement if it is in the same location of executable * [RUNTIME] Fixed - bug calling finalization function twice during end of program causing possible crash sometimes * [RUNTIME] Fixed - bug causing crash when try to import a DLL with IMPORT statement * [RUNTIME] Fixed - bug potential crash when try to unload DLL's not loaded when program ends
* [CORE] Changed - all files except divc.c, and divforma.c are now better formatted. * [CORE] Changed - saved all source files with UTF-8 encoding * [CORE] Changed - mnemonics opcodes from "lname" to "DIVBC_name" to avoid compile error or conflicts in modern compilers/libraries (especially on Windows) * [CORE] Changed - homogenization of all definitions/declarations of structures with "_t_name" and "t_name" prefixes * [CORE] Changed - improved all DIV function names with "DIV" prefix * [CORE] Changed - improved all mode8 internal function names with "m8" prefix * [CORE] Changed - improved all audio internal function names with "DIV" prefix * [CORE] Changed - improved all flic internal function names with "DIV" prefix
* [CORE] Changed - saved source file with UTF-8 encoding * [CORE] Changed - mnemonics opcodes from "lname" to "DIVBC_name" to avoid compile error or conflicts in modern compilers/libraries (especially on Windows)
|
Are you redoing this patch? I'm in the middle of trying to merge this |
|
Hello, I simply closed the request for conflicts resulting from John's latest merged pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.