Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument features_extractor to ActorCriticPolicy.extract_features #1710

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

qgallouedec
Copy link
Collaborator

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@qgallouedec
Copy link
Collaborator Author

To fix mypy:

File "/home/runner/work/stable-baselines3/stable-baselines3/stable_baselines3/common/policies.py", line 645, in ActorCriticPolicy: Overriding method signature mismatch [signature-mismatch]
  Base signature: 'def BaseModel.extract_features(self, obs: Any, features_extractor: stable_baselines3.common.torch_layers.BaseFeaturesExtractor) -> Any'.
  Subclass signature: 'def ActorCriticPolicy.extract_features(self, obs: Any) -> Union[Any, Tuple[Any, Any]]'.
  Not enough positional parameters in overriding method.

@qgallouedec qgallouedec requested a review from araffin October 6, 2023 14:38
Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)
similar fix is needed for sb3 contrib?

@araffin araffin merged commit c6bf251 into master Oct 9, 2023
4 checks passed
@araffin araffin deleted the fix_extract_features_signature branch October 9, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants