-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.2.1: Hotfix file closing #1754
Conversation
For clarity, I checkout back to before #1742. |
thanks, i like it, much better than adding a new parameter =) |
The rl-zoo3 CI seems to pass locally with this fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot =)
much better than my original solution and now we have consistent behavior!
* new closing policy * revert DLR-RM#1742 * Add tests and update changelog --------- Co-authored-by: Antonin Raffin <[email protected]>
Description
closes #1751
Motivation and Context
Types of changes
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line