Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.1: Hotfix file closing #1754

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Release 2.2.1: Hotfix file closing #1754

merged 4 commits into from
Nov 17, 2023

Conversation

qgallouedec
Copy link
Collaborator

@qgallouedec qgallouedec commented Nov 17, 2023

Description

closes #1751

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@qgallouedec
Copy link
Collaborator Author

For clarity, I checkout back to before #1742.

@qgallouedec qgallouedec requested a review from araffin November 17, 2023 17:40
@araffin
Copy link
Member

araffin commented Nov 17, 2023

thanks, i like it, much better than adding a new parameter =)

@qgallouedec qgallouedec marked this pull request as draft November 17, 2023 18:15
@qgallouedec
Copy link
Collaborator Author

The rl-zoo3 CI seems to pass locally with this fix.
@araffin Can I leave versioning and changelog to you?

@qgallouedec qgallouedec marked this pull request as ready for review November 17, 2023 18:21
@araffin araffin changed the title Hotfix file closing Release 2.2.1: Hotfix file closing Nov 17, 2023
Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot =)
much better than my original solution and now we have consistent behavior!

@araffin araffin merged commit e3dea4b into master Nov 17, 2023
4 checks passed
@araffin araffin deleted the fix/resource-warning_alt branch November 17, 2023 22:50
friedeggs pushed a commit to friedeggs/stable-baselines3 that referenced this pull request Jul 22, 2024
* new closing policy

* revert DLR-RM#1742

* Add tests and update changelog

---------

Co-authored-by: Antonin Raffin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[breaking change]: save closes files now
2 participants