Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruff and documentation for hf sb3 #1866

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Update ruff and documentation for hf sb3 #1866

merged 5 commits into from
Mar 11, 2024

Conversation

araffin
Copy link
Member

@araffin araffin commented Mar 11, 2024 •
edited
Loading

Related to #1852 , weight_only=True doesn't work unfortunately, because we need to allow gymnasium imports.
Related to #1831

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

This was referenced Mar 11, 2024
Merged
Open
@araffin araffin changed the title Update ruff and load weights only when using torch.load() Update ruff and documentation for hf sb3 Mar 11, 2024
@araffin araffin merged commit 8b3723c into master Mar 11, 2024
4 checks passed
@araffin araffin deleted the feat/load-weights-only branch March 11, 2024 12:53
friedeggs pushed a commit to friedeggs/stable-baselines3 that referenced this pull request Jul 22, 2024
@araffin @friedeggs
Update ruff and documentation for hf sb3 (DLR-RM#1866)
ce2986c 
* Update ruff

* Only load weights with `torch.load()` to avoid security issues

* Update doc about HF integration and remote code execution

* Fix doc build

* Revert weight_only=True for policies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@araffin