Feature/12 reccomend view #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import kr.co.nottodo.databinding.ItemRecommendBinding | ||
| import kr.co.nottodo.presentation.toplevel.recommendation.data.Recommendationdata | ||
|
|
||
| class RecommendationAdapter(private val tools: List<Recommendationdata>) : |
There was a problem hiding this comment.
Adapter를 생성할 때는 list는 안받습니다!
이렇게 구현이 된다면 순서를 생각해봤을 때
-
서버에서 리스트 데이터를 받는다.
-
받은 리스트 데이터를 활용해 어댑터를 만든다.
이 순서가 되는데 그게 아니라
-
어댑터를 만들어 놓는다.
-
서버에서 데이터가 들어오면 어댑터에 비어 있는 리스트에 담아둔다!
는 순서로 바꿔야 됩니다!
| import kr.co.nottodo.databinding.ItemRecommendBinding | ||
| import kr.co.nottodo.presentation.toplevel.recommendation.data.Recommendationdata | ||
|
|
||
| class RecommendViewHolder(val binding: ItemRecommendBinding) : RecyclerView.ViewHolder(binding.root) |
There was a problem hiding this comment.
요건 따로 파일하나 만들어서 관리하는건 어떨까요?!
| return binding.root | ||
| } | ||
|
|
||
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { |
There was a problem hiding this comment.
아마 RecyclerView의 제약조건이 match 로 걸려서 꽉 차보이는 거 일 거같아요.
width = match_parent, height = wrap_content로 변경해보면 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👻 작업한 내용
추천뷰 fragment recyclerview 구현 검토
🎤 PR Point
코드리뷰 해주세용,,
📸 스크린샷
📮 관련 이슈