Embed the community/collection on the edit EPerson page #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-7.6' # Conflicts: # src/app/access-control/epeople-registry/eperson-form/eperson-form.component.ts # src/app/shared/object-detail/my-dspace-result-detail-element/item-detail-preview/item-detail-preview.component.ts
alexandrevryghem
added
bug
authorization
This was referenced Dec 6, 2024
tdonohue
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! I finally got back to reviewing this today. Gave it a quick test and it works as described.
alexandrevryghem
deleted the
w2p-117573_remove-observable-function-calls-from-template_contribute-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
dspace-7_xbackport: [Port dspace-7_x] Removed observable function calls from template (part 1) #3721dspace-8_xbackport: [Port dspace-8_x] Removed observable function calls from template (part 1) #3738Description
Fixed issue where the edit EPerson page didn't show the comcol names when they weren't already cached. Also removed a template observable call from
ItemDetailPreviewComponent.Instructions for Reviewers
List of changes in this PR:
Group's linkedobjectin the group overview of editEPerson. Otherwise only already cached communities and collections would have a visible nameChecklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.