Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#145] 커뮤니티 api 연결, 반응형으로 수정 #163

Merged
merged 18 commits into from
Jan 26, 2024
Merged

Conversation

SujinKim1127
Copy link
Member

@SujinKim1127 SujinKim1127 commented Jan 2, 2024

Issue

Description

  • 커뮤니티 api (상세정보 조회, 좋아요 클릭/해제, 스크랩) 연결 완료했습니다!
  • 반응형으로 수정 완료했습니다!

Check List

  • PR 제목을 커밋 규칙에 맞게 작성
  • PR에 해당되는 Issue를 연결 완료
  • 적절한 라벨 설정
  • 작업한 사람 모두를 Assign
  • 작업한 팀에게 Code Review 요청 (Reviewer 등록)
  • main 브랜치의 최신 상태를 반영하고 있는지 확인

@SujinKim1127 SujinKim1127 requested a review from chan0310 January 2, 2024 11:28
Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daitssu-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 4:25am

@SujinKim1127 SujinKim1127 self-assigned this Jan 2, 2024
@SujinKim1127 SujinKim1127 added feat 🔧 새로운 기능 관련된 Issue style 💄 스타일만 변경하는 Issue labels Jan 2, 2024
@SujinKim1127 SujinKim1127 linked an issue Jan 2, 2024 that may be closed by this pull request
src/components/community/info/CommunityInfo.tsx Outdated Show resolved Hide resolved
return (
<Comment
key={comment.commentId}
nickname={''}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nickname 데이터는 없나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네,,,,, 서버에서 userId는 주는데 닉네임을 안줬습니다ㅠㅠ

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

닉네임 api 변경 요청 해야할 것 같아요! 뷰에서 사용하는데 api에 꼭 필요할 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵!!!

halfmoon-mind and others added 2 commits January 4, 2024 21:59
* feat: Route에 따른 header 조건 지정

* fix: 바텀네비게이션 announce -> notice로 수정

* refactor: style 코드들 정렬

* feat: 더보기 클릭 라우팅 추가

* feat: 코드 스타일 업데이트

* feat: 스크롤 코드 삭제

* feat: bottom nav bar true로 설정

* feat: 상위 3개만 출력하도록 변경

* feat: 로그인에서 utility header 추가

* refactor: 불필요한 코드 삭제

* refactor: PR시 빌드 확인 코드 삭제

* feat: main에서 api 콜 수정

* refactor: header 설정 추가

* fix: storybook 업데이트
return response.data;
} catch (error) {
if (axios.isAxiosError(error)) {
console.log(error.response?.data);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요런거 주석처리 해놓는게 좋을거 같아요!

jwo0o0 and others added 8 commits January 8, 2024 21:44
* style: global.css body 요소에 height 설정, padding 추가(네비게이션바 100px)

* style: 랜딩 페이지 배경 이미지 position:fixed로 변경

* fix: 랜딩 페이지에서 헤더 미노출 로직 추가
Copy link
Member

@halfmoon-mind halfmoon-mind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿잡 👍

@SujinKim1127 SujinKim1127 merged commit e84df39 into main Jan 26, 2024
2 checks passed
@SujinKim1127 SujinKim1127 deleted the feat/#145 branch January 26, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 🔧 새로운 기능 관련된 Issue style 💄 스타일만 변경하는 Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 - 3 수진
3 participants