Optiplex SeaBIOS + TXT #583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipleple
force-pushed
the
optiplex_seabios
branch
5 times, most recently
from
3ee1d02 to
620e1cd
Compare
krystian-hebel
requested changes
Nov 29, 2024
build.sh
Outdated
| DEFCONFIG="configs/config.dell_optiplex_9010_sff_uefi_txt" | ||
| FW_VERSION=v0.1.0-rc1 | ||
| local CONFIG=$1 | ||
| local FW_VERSION=$2 |
There was a problem hiding this comment.
Why not use the same way of getting the version as other platforms? That way the script wouldn't have to be updated with each release.
build.sh
Outdated
| } | ||
|
|
||
| SDKVER="2023-11-24_2731fa619b" | ||
|
|
||
|
|
||
| function build_optiplex_9010 { | ||
| DEFCONFIG="configs/config.dell_optiplex_9010_sff_uefi_txt" | ||
| FW_VERSION=v0.1.0-rc1 | ||
| local CONFIG=$1 |
There was a problem hiding this comment.
Lets keep it named DEFCONFIG to mark that it isn't full config.
| CONFIG_VENDOR_DELL=y | ||
| CONFIG_BOARD_DELL_OPTIPLEX_9010=y | ||
| CONFIG_FMDFILE="src/mainboard/dell/snb_ivb_workstations/default.fmd" |
There was a problem hiding this comment.
It would be better to add this as default to mainboard Kconfig instead, something like:
config FMDFILE
default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/default.fmd"
Top-down resource allocation causes trouble with iGPU initialization, leading to a full platform freeze using an OS GUI. Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
…on to Kconfig from defconfigs Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
filipleple
force-pushed
the
optiplex_seabios
branch
from
5ec274d to
68b25a3
Compare
Signed-off-by: Filip Lewiński <[email protected]>
filipleple
force-pushed
the
optiplex_seabios
branch
from
68b25a3 to
39e6ccf
Compare
filipleple
force-pushed
the
optiplex_seabios
branch
from
c0ec1b9 to
ed38edb
Compare
miczyg1
reviewed
Dec 19, 2024
Comment on lines
24
to
26
| CONFIG_INTEL_TXT_BIOSACM_FILE="IVB_BIOSAC_PRODUCTION.BIN" | ||
| CONFIG_INTEL_TXT_SINITACM_FILE="SNB_IVB_SINIT_20190708_PW.bin" | ||
| CONFIG_SMSC_SCH5545_EC_FW_FILE="sch5545_ecfw.bin" |
There was a problem hiding this comment.
These blobs are being added in DTS during deployment/update. They should not be here in the config.
There was a problem hiding this comment.
yes, I'll only leave them in for the WIP debug phase for convenience
Signed-off-by: Filip Lewiński <[email protected]>
filipleple
force-pushed
the
optiplex_seabios
branch
from
ed38edb to
cbc048d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.