terms: tos-update

[Stanislaw-bnk]

No description provided.

[gosiastyba]

@Stanislaw-bnk Przyznam, że nie jestem pewna, jakie mamy praktyki do mergowania w przypadku, gdy nie wszystkie checki są spełnione (tutaj ten nie jest: SEO CI / linkChecker (pull_request) ) (@artur-rs może pomożesz?) Poza tym jednym nie mam więcej uwag.
EDIT:
ENG: I admit that I'm not sure what practices we have for merging when not all checks are met (here this one is not: SEO CI / linkChecker (pull_request) ) (@artur-rs maybe you can help?) Apart from this one, I don't have any more comments.

[pietrushnic]

@gosiastyba This is a public repo where we use English. I already wrote internally what the issue is and how @Stanislaw-bnk should address that.

[Stanislaw-bnk]

The issue with the broken link is in the style.html directory. It is indeed a 404, but I'm not quite sure to what website should I change it (https://fontawesome.com/ ?), and if the change won't affect anything negatively on the Dasharo website if I just delete the link.
The broken links checker:
docker run --init -it --rm -w $(pwd) -v $(pwd):$(pwd) lycheeverse/lychee --max-redirects 10 -a 403,429,500,502,503,999 when I tried to run it locally returned:

[sbieniek@3M11 dasharo-website]$ docker run --init -it --rm -w $(pwd) -v $(pwd):$(pwd) lycheeverse/lychee --max-redirects 10 -a 403,429,500,502,503,999
error: the following required arguments were not provided:
  <inputs>...

Usage: lychee --max-redirects <MAX_REDIRECTS> --accept <ACCEPT> <inputs>...

[pietrushnic]

@Stanislaw-bnk about the broken link checker command, please create an issue and assign it to @Asiderr

Regarding fontawesome, did you happen to try ChatGPT like I suggested?
Have you tried to render the website locally after removing the fontawsome link?
Did the page work correctly?

[Stanislaw-bnk]

Yes, I have just tried to delete the links, the page rendered correctly at first sight, didn't notice any change.
PR with the fix: #55

[Stanislaw-bnk]

A new issue with the broken links checker: #56

[pietrushnic]

@Stanislaw-bnk #55 merged.

[gosiastyba]

@gosiastyba This is a public repo where we use English.

@pietrushnic Understood. For clarity, I have included an English version of the comment.

[pietrushnic]

@Stanislaw-bnk if you rebase on top of develop it should be fixed

[Asiderr]

@Stanislaw-bnk @pietrushnic I responded in #56. 404 is an actual issue and must be fixed (not ignored) before merging.

[pietrushnic]

404 is an actual issue and must be fixed (not ignored) before merging.

@Asiderr sounds like automatic reply, this is precisely what @Stanislaw-bnk did in #55

[Stanislaw-bnk]

if you rebase on top of develop it should be fixed

@artur-rs Having a problem doing that, need a little help. Should I just follow the same instructions like for the 3mdeb website?
After successful deployment on the beta environment, if a whole set of patches is merged in the develop branch, open a new PR to main. The reporter will verify changes and publish prod env.
Would like to rebase the develop to main.
When trying to compare main to develop it states: main is up to date with all commits from develop

[pietrushnic]

@Stanislaw-bnk No, you are not allowed to rebase the develop branch. Your changes are on tos-dasharo branch and that branch should b rebased on most recent develop. Please never touch your branches unless explicitly asked for that.

[pietrushnic]

@Stanislaw-bnk @gosiastyba those changes were not merged, when you plan to fix this PR?

[Stanislaw-bnk]

@Asiderr I would like to resolve the merge conflicts here, but the linkchecker says: The logs for this run have expired and are no longer available.. How should I proceed here?

[Asiderr]

@Stanislaw-bnk You have to rerun this pipeline. Trigger once again all of the tests.

[Stanislaw-bnk]

You have to rerun this pipeline. Trigger once again all of the tests.

How can I re-run the tests without making any additional changes in the file?

[Asiderr]

@Stanislaw-bnk https://github.com/Dasharo/dasharo-website/actions/runs/7693514729?pr=54 -> ... -> Rerun job

[Stanislaw-bnk]

Rerun job

I know, the problem is, there is no such option, only Create status badge.

[Stanislaw-bnk]

@artur-rs Could you please help with the linkchecker fail here?

[artur-rs]

@Stanislaw-bnk I do not see this option as well, which is strange. Even the linkChecker log is empty.

[artur-rs]

@Stanislaw-bnk rebase did the work. Merging