Dynamic bmm #195
Open
Dynamic bmm #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out statically" This reverts commit 6d2f767.
…imeout Signed-off-by: Michał Żygowski <[email protected]>
Move generating the HII opcodes to the library constructor. Previously the opcodes were generated on form entry, which prevented the F9 (reset to defaults) to not apply to the dynamically generated options if BMM was not enetered. NOw, when the opcodes are generated in the library constructor, the dynamically generated options are "visible" from any level of the setup browser and F9 can restore defaults from any browser level. There was a specific need to generate those dynamic options on form entry because of legacy UI library dependency. As we do not use legacy UI nor CSM, we do not have to worry about it. Signed-off-by: Michał Żygowski <[email protected]>
|
Did a quick test on OVMF and nothing exploded. The timeout also works as expected (F9 can reset it fro many level of setup browser without a need to enter BMM). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.