-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove regression-qemu.sh #348
base: develop
Are you sure you want to change the base?
Conversation
scripts/regression.sh
Outdated
export RTE_IP=127.0.0.1 | ||
export SNIPEIT_NO="no" | ||
compatibility_tests=( | ||
"dasharo-compatibility/custom-boot-menu-key.robot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I am not a huge fan of such solution.
Ideally, we simply execute the regression.sh
as we do for any other platform, and only the required tests are executed, thanks to the correctly set test flags.
That would be the goal towards resolving the linked issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this what happens in this script? If we set CONFIG
to qemu
, only some of the tests are executed (the ones that were listed in regression-qemu.sh
, so I assume those can run on QEMU)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PLangowski But this should be resolved by properly setting support flags in platform-configs/qemu.robot, not be the if-else here. This MR should require no modifications to regression.sh script whatsoever.
26cbcd3
to
7c18adb
Compare
090c2e5
to
de9e2e8
Compare
Signed-off-by: Pawel Langowski <[email protected]>
de9e2e8
to
4ddf52f
Compare
@PLangowski You pushed some WIP commit in July, do you intend to finalize this at some point? Do you know how? |
@macpijan I got stuck here. For some reason RF fails to establish a serial connection over telnet when running |
@PLangowski Well, if we look in the log, the obvious difference is the addition of when running the whole regression. This comes from the |
Yes, but I have modified it to only run |
closes #320