Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regression-qemu.sh #348

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

PLangowski
Copy link
Contributor

closes #320

@PLangowski PLangowski linked an issue Jul 3, 2024 that may be closed by this pull request
export RTE_IP=127.0.0.1
export SNIPEIT_NO="no"
compatibility_tests=(
"dasharo-compatibility/custom-boot-menu-key.robot"
Copy link
Contributor

@macpijan macpijan Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I am not a huge fan of such solution.
Ideally, we simply execute the regression.sh as we do for any other platform, and only the required tests are executed, thanks to the correctly set test flags.

That would be the goal towards resolving the linked issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this what happens in this script? If we set CONFIG to qemu, only some of the tests are executed (the ones that were listed in regression-qemu.sh, so I assume those can run on QEMU)

Copy link
Contributor

@macpijan macpijan Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PLangowski But this should be resolved by properly setting support flags in platform-configs/qemu.robot, not be the if-else here. This MR should require no modifications to regression.sh script whatsoever.

@PLangowski PLangowski closed this Jul 18, 2024
@PLangowski PLangowski force-pushed the remove-regression-qmeu branch from 26cbcd3 to 7c18adb Compare July 18, 2024 10:31
@PLangowski PLangowski reopened this Jul 18, 2024
@PLangowski PLangowski force-pushed the remove-regression-qmeu branch 2 times, most recently from 090c2e5 to de9e2e8 Compare July 30, 2024 09:25
Signed-off-by: Pawel Langowski <[email protected]>
@PLangowski PLangowski force-pushed the remove-regression-qmeu branch from de9e2e8 to 4ddf52f Compare July 30, 2024 11:31
@macpijan
Copy link
Contributor

macpijan commented Dec 2, 2024

@PLangowski You pushed some WIP commit in July, do you intend to finalize this at some point? Do you know how?

@PLangowski
Copy link
Contributor Author

@macpijan I got stuck here. For some reason RF fails to establish a serial connection over telnet when running regression.sh on qemu. The problem does not occur when I run the tests separately.
dasharo-compatibility_log.txt

@macpijan
Copy link
Contributor

macpijan commented Dec 3, 2024

@PLangowski Well, if we look in the log, the obvious difference is the addition of

image

when running the whole regression.

This comes from the dasharo-compatibility/__init__.robot. You should find answer there.

@PLangowski
Copy link
Contributor Author

PLangowski commented Dec 3, 2024

Yes, but I have modified it to only run Prepare Test Suite, which works when running single test files. When comparing run.sh vs single test file logs, I couldn't find any difference except for the failing telnet keyword. I might have missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove regression-qemu.sh script
2 participants